Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Handle & Translate Exceptions #42626

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

sanchitmalhotra126
Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 commented Sep 22, 2021

Handles and translates playground exceptions into user friendly messages. Note: for this exception handling to work fully, this requires a change in Javabuilder to not re-wrap JavabuilderExceptions when they are thrown from student code. (PR: code-dot-org/javabuilder#119)

Links

Spec: https://docs.google.com/document/d/1Moo2s5EXZRp5rMg1VW9jlOqs_GeMN5yjU8FJgoqOEMk/edit#bookmark=id.8mzt0ejeo6eg
JIRA: https://codedotorg.atlassian.net/browse/CSA-830

Testing story

Tested locally.

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sanchitmalhotra126 sanchitmalhotra126 requested a review from a team September 22, 2021 18:01
@sanchitmalhotra126 sanchitmalhotra126 requested a review from a team as a code owner September 22, 2021 18:01
@sanchitmalhotra126 sanchitmalhotra126 merged commit 8b59cb6 into staging Sep 22, 2021
@sanchitmalhotra126 sanchitmalhotra126 deleted the playground-exceptions branch September 22, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants