Javalab: play sound in Playground when signal received #42642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This was referenced Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plays a sound when PLAY_SOUND signal received from Javabuilder. Stops playing sound when a user clicks the "Stop" button.
Also includes this bit of cleanup to prevent 404 errors when trying to reset background images when running a program.
Links
Testing story
I manually tested this, where I was able to play a sound, stop that sound when I hit the stop button, and got an appropriate error when I tried to use a sound file that was not in the asset manager. I also added unit tests similar to those for setting a background image.
This change will also result in us running the onStop() method in Neighborhood -- it looks reasonable, and I ran (and stopped) on a simple Neighborhood level with this change without issue. Theater has no onStop() implemented.