[Poetry][HOC] Save selected poem in progress #42871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/src/p5lab/poetry/Poetry.js
Outdated
Comment on lines
12
to
16
| if (config.level.selectedPoem) { | ||
| getStore().dispatch(setPoem(config.level.selectedPoem)); | ||
| } else if (this.level.defaultPoem) { | ||
| getStore().dispatch(setPoem(POEMS[this.level.defaultPoem])); | ||
| } |
There was a problem hiding this comment.
this is subjective, but i think we can simplify this bit of code:
const poem = config.level.selectedPoem || POEMS[this.level.defaultPoem];
if (poem) {
getStore().dispatch(poem);
}There was a problem hiding this comment.
ah, yeah, I like that better! thanks!
| @@ -130,6 +130,10 @@ function initProjects() { | |||
| getSelectedSong: function() { | |||
| return false; | |||
| }, | |||
| setSelectedPoem: function() {}, | |||
There was a problem hiding this comment.
i've run into this situation before (having to stub sourceHandler on pixelation) -- we should not have to do this 🙃 i've logged STAR-1785 to refactor this away
There was a problem hiding this comment.
thanks for logging that!
maddiedierker
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily modeled after #25466
Saves the selected poem in the project sources so that it persists on page reload and share
Initial level load with default poem:
Share view with selected poem:
After remix with custom poem:
