Make reset version message visible in dark mode in Javalab #42924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized during today's curriculum sync that it appeared we had no message to students when they are about to reset their project to the template on a project-backed level. Turned out this was only an issue in dark mode, where we were putting white text on a white background.
This change also makes a loading spinner visible that was not visible when you clicked to "Restore" a previous version, and would make an error message visible if we were to get a bad response from the server when fetching versions.
Testing story
Tested manually that the message is now visible in dark mode when you try to reset to the template, and that the loading spinner appears on choosing a previous version. I did not test the error case.