Javalab: Pass execution type parameter to Javabuilder #42938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/src/javalab/Javalab.js
Outdated
| }; | ||
|
|
||
| Javalab.prototype.onTest = function() { | ||
| // TODO: Add any necessary pre-run steps here (incrementing attempts count, resetting mini-app, etc) |
There was a problem hiding this comment.
In onRun we save the project, reset the mini-app, and increment the attempt count. Do we need to do any of that here as well?
There was a problem hiding this comment.
Hmm ping Hannah and Mike about this (they're not on github often, so it's best to tag them in Slack). We do need to save the project (so Javabuilder can get the right version of the code), and we may want to reset the mini-app, but I have no idea about whether we should record a milestone. Hannah & Mike will likely have opinions here.
molly-moen
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes a new "execution type" parameter to Javabuilder to eventually support running tests and other configurations (see: code-dot-org/javabuilder#136). For now, no behavior should be changed - the
onRunfunction now opens a connection to Javabuilder with an execution type of "RUN", and later, theonTestfunction can be used to open a connection with an execution type of "TEST".Links
Testing story
Tested locally on All The Things levels Confirmed that standard Javalab behavior is unchanged.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: