Revert "Revert "Make teacher banner dismiss-able"" #42968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescodeorg
approved these changes
Oct 13, 2021
| <SpecialAnnouncementActionBlock | ||
| announcement={announcement} | ||
| marginBottom={marginBottom} | ||
| /> | ||
| </div> | ||
| <Button | ||
| id="marketing-announcement-banner--dismiss" |
There was a problem hiding this comment.
Just checking that the two dashes before dismiss was intentional.
There was a problem hiding this comment.
Yeah I was using that to separate the context (marketing-announcement-banner) from the specific element (dismiss), which is a made-up convention that I decided to apply here..
maureensturgeon
deleted the
revert-42960-revert-42912-maureen/LP-2039-make-banner-excusable-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #42960
Original PR: #42912
I merged the PR to make the teacher homepage banner dismiss-able. This ended up causing failing tests in DTT. I reverted the change and spent some time fixing tests and refactoring. This is attempt 2!