Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poetry][HOC] Only set poem state for poetry_hoc levels #42977

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Oct 13, 2021

reported via slack thread

If there's no poem dropdown, we don't want to set the poem state even if the user somehow has a poem set in their progress or the level has a default poem. When there's no poem dropdown, the poem must be set using blocks.

@ajpal ajpal requested a review from a team October 13, 2021 20:18
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should clear default_poem from the level when the state changes in levelbuilder rather than explicitly checking the standalone app before setting a poem

@ajpal ajpal merged commit 53d0563 into staging Oct 13, 2021
@ajpal ajpal deleted the oct13-default-poem branch October 13, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants