Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data to NoMethodError for progress #42982

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

maureensturgeon
Copy link
Contributor

@maureensturgeon maureensturgeon commented Oct 13, 2021

We've had an error on /dashboardapi/section_level_progress/<section> which has been increasing in frequency over the last few months:
Screen Shot 2021-10-13 at 2 30 58 PM

The error is NoMethodError: undefined method []=' for nil:NilClass, which I determined would be caused for a bubble choice level if a student does not have overall progress for the level but has progress on a sublevel. It's hard for me to imagine how this could happen. I reloaded the endpoint with the same parameters that it failed with and got 200s. I logged in as various teachers looking for a pattern that could be causing this among their student progress with no luck.

I need more data. So I've rescued the error and re-raised it with more information about the specific student and level.

Links

Error: https://app.honeybadger.io/projects/3240/faults/80852799/01FHX8JY4SPJER77W141CNQ155

Testing story

I've tested locally that raising the error results in the expected message:
Screen Shot 2021-10-13 at 2 37 13 PM

Follow-up work

Once I have more data, I'll look into the specific levels and students that this is happening for.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maureensturgeon maureensturgeon changed the title Add data to error Add data to NoMethodError for progress Oct 13, 2021
@maureensturgeon maureensturgeon force-pushed the maureen/add-data-to-error-user-progress branch from 0150498 to 1a31409 Compare October 13, 2021 21:41
@maureensturgeon maureensturgeon requested review from a team and sureshc October 13, 2021 21:41
@maureensturgeon maureensturgeon marked this pull request as ready for review October 13, 2021 21:48
@maureensturgeon maureensturgeon merged commit 390d974 into staging Oct 13, 2021
@maureensturgeon maureensturgeon deleted the maureen/add-data-to-error-user-progress branch October 13, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants