Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Honeybadger error #43181

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

maureensturgeon
Copy link
Contributor

This is an alternative solution to #43023.

In the solution presented in #43023, I added additional logic to determine the primary sublevel given the hashes of data. This complicates the overall logic and decreases maintainability for an error that doesn't occur very often. The new solution presented here does not add much additional logic, the downside is that users may be able to see the bug manifested in unexpected state of a bubble choice parent bubble.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@jamescodeorg jamescodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to go with this simpler patch for now and revisit the more costly fix if we continue to get feedback on it. I'm also hoping that we'll get to rework the logic for the section progress table substantially in the next year which will give us another opportunity to address this. Thanks for taking another pass at this!

@maureensturgeon maureensturgeon merged commit 27582e5 into staging Oct 26, 2021
@maureensturgeon maureensturgeon deleted the maureen/honeybadger-error-progress branch October 26, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants