Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOC][Poetry] Small tweaks for validation code #43183

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Oct 26, 2021

A couple things came up while I was doing the last pass of validation code on levelbuilder:

  1. We need to set validationInfo.backgroundEffect when the background image block is used so that it counts as having a background effect for validation code
  2. Setting validationInfo.endFrame to POEM_DURATION means that the level ends as soon as the poem ends, but it looks better to have some buffer time. Setting it to POEM_DURATION * 1.25 will feel more natural
  3. Slight adjustment to validation strings for level 7

@ajpal ajpal requested a review from a team October 26, 2021 02:22
@ajpal ajpal requested a review from a team as a code owner October 26, 2021 02:43
@ajpal ajpal merged commit 0432a86 into staging Oct 26, 2021
@ajpal ajpal deleted the oct25-validation-tweaks branch October 26, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants