Update the content of the principal approval application form #43212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-dot-org
force-pushed
the
csa-principal
branch
2 times, most recently
from
4e276c9
to
262c6da
Compare
tim-dot-org
force-pushed
the
csa-principal
branch
2 times, most recently
from
f2d6677
to
af059db
Compare
tim-dot-org
force-pushed
the
csa-principal
branch
2 times, most recently
from
6319158
to
ac8ee0c
Compare
davidsbailey
approved these changes
Nov 9, 2021
apps/src/code-studio/pd/application/principalApproval/PrincipalApprovalComponent.jsx
Show resolved
Hide resolved
| @@ -211,6 +228,7 @@ def additional_text_fields | |||
| [:committed_to_diversity, TEXT_FIELDS[:other_please_explain], :committed_to_diversity_other], | |||
| [:replace_which_course_csd, TEXT_FIELDS[:other_please_explain], :replace_which_course_csd_other], | |||
| [:replace_which_course_csp, TEXT_FIELDS[:other_please_explain], :replace_which_course_csp_other], | |||
| [:replace_which_course_csa, TEXT_FIELDS[:other_please_explain], :replace_which_course_csa_other], | |||
There was a problem hiding this comment.
would it be possible to provide a screenshot of where this set of changes shows up in the application?
There was a problem hiding this comment.
to be more specific, I'm asking about where the changes on the ruby side show up -- I think I can see where the changes on the jsx side show up.
There was a problem hiding this comment.
here is the form, not sure what you mean by 'where they show up on the ruby side'?
There was a problem hiding this comment.
Haha, sorry, I was trying to ask where the ruby changes show up in the UI. Thanks!
tim-dot-org
force-pushed
the
csa-principal
branch
from
ac8ee0c
to
5614c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the principal approval application form to functional component + content updates. Nothing particularly different here apart from one small upgrade to the FormController.
open question: should the school data on the form be pre-filled from the teacher application + what happens when thats different and leads to a different regional partner?
Links
Testing story
Manually tested, and updated unit tests