Code Review Groups: add group management UI to modal #43281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
ben/code-review-groups/update-styling-add-containers
to
staging
October 29, 2021 22:17
molly-moen
approved these changes
Oct 29, 2021
| body={codeReviewGroupsManager} | ||
| isOpen={isDialogOpen} | ||
| handleClose={onDialogClose} | ||
| fixedWidth={1000} |
There was a problem hiding this comment.
nit: constant for 1000?
| } | ||
|
|
||
| ManageCodeReviewGroups.propTypes = {buttonContainerStyle: PropTypes.object}; | ||
|
|
||
| const names = [ |
There was a problem hiding this comment.
nit: add a todo to remove this fake data at some point
There was a problem hiding this comment.
Added a Jira link (and included this in the cleanup task).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts rough version of Code Review Groups manager in a modal (hidden behind an experiment flag) where it will ultimately appear. We should continue development of this feature (hooking up to back end, addtional UI work) here rather than in Storybook.
Testing story
Tested manually.