Fixed failed render due to returning undefined rather than null #43505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where no inline dropdown menu should render, such as when reviewing another student's code, the InlineDropdownMenu would return undefined rather than null. This caused the React Error https://reactjs.org/docs/error-decoder.html/?invariant=152&args[]=e to be thrown which translates to the following message:
e(...): Nothing was returned from render. This usually means a return statement is missing. Or, to render nothing, return null.
This caused the parent elements to all unmount, causing a blank screen.
This was reported during a call with CSA pilot teachers.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: