Increase apps/ integration test timeouts #43539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 11, 2021 12:55
maddiedierker
changed the title
ajpal
reviewed
Nov 11, 2021
| @@ -6,7 +6,7 @@ module.exports = { | |||
| levelId: '4_11', | |||
| tests: [ | |||
| { | |||
| description: 'Top Solve: Repeat 9 times, right 80', | |||
| description: 'Top Solve: Repeat 2x, right 80', | |||
There was a problem hiding this comment.
nothing, i just noticed it was out of date -- we changed the code from a 9x repeat to a 2x repeat so i updated this to match
ajpal
approved these changes
Nov 11, 2021
maddiedierker
changed the title
snickell
pushed a commit
that referenced
this pull request
Feb 3, 2024
Increase apps/ integration test timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaky because it occasionally doesn't finish executing the level before the timeout. This has been happening more frequently lately, so increasing the timeout while *Labs discusses what we're going to do with the tests in
integration/in general. This test and others have been flaky since they written (see history in previous location of apps/test/solutions), and they are all built on a custom test harness that isn't maintained and nobody really understands anymore.Links