Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the parameters on the programming expression show page #43548

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Show the parameters on the programming expression show page #43548

merged 3 commits into from
Nov 16, 2021

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Nov 12, 2021 •
edited

Mostly modeled on the tables on curriculumbuilder, such as the one at https://curriculum.code.org/docs/applab/button/

Screen Shot 2021-11-11 at 3 57 13 PM

Testing story

manually tested, unit tests

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor requested a review from a team as a code owner November 12, 2021 00:28
@bethanyaconnor bethanyaconnor requested a review from a team November 12, 2021 17:47
tim-dot-org
tim-dot-org approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@tim-dot-org tim-dot-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice!

@bethanyaconnor bethanyaconnor merged commit 40ca06f into staging Nov 16, 2021
@bethanyaconnor bethanyaconnor deleted the programming-expressions-show-page-parameters branch November 16, 2021 00:24
snickell pushed a commit that referenced this pull request Feb 3, 2024
@bethanyaconnor
Merge pull request #43548 from code-dot-org/programming-expressions-s…
c148a9a 
…how-page-parameters

Show the parameters on the programming expression show page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@tim-dot-org tim-dot-org tim-dot-org approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bethanyaconnor @davidsbailey @tim-dot-org