-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export summer workshops to gdrive #43566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megcrenshaw
changed the title
Summer workshops export
Export summer workshops to gdrive
Nov 12, 2021
tim-dot-org
approved these changes
Nov 12, 2021
Pd::Workshop. | ||
where(subject: subjects). | ||
scheduled_start_on_or_after(EARLIEST_WORKSHOP_START_DATE). | ||
scheduled_start_on_or_before(LATEST_WORKSHOP_START_DATE).find_each do |workshop| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making this much more readable!
tim-dot-org
approved these changes
Nov 12, 2021
snickell
pushed a commit
that referenced
this pull request
Feb 3, 2024
Export summer workshops to gdrive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the existing export file to use a new gsheet. I followed the process detailed in #39120, which references #32597.
Testing story
Tested end-to-end locally with development secrets configured in Secret Manager. I added the configuration needed in
development.yml.erb
in #43476 for local testing––to overwrite values in the Secrets Manager, put inlocals.yml
.Things to check:
applications_2022_2023_gsheet_key
for the file in different environments. Should be in all environments to avoid errors. The key in the development environment is different for testing.locals.yml
file.If you are wanting to put credentials into your
locals.yml
file, it should look something likeLet me know if you're wanting to test locally and running into trouble.
Deployment strategy
Follow-up work
Privacy
Security
All secrets are in the AWS Secrets Manager.
Caching
PR Checklist: