Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid accidental EC2 recreation #43576

Merged
merged 5 commits into from
Nov 16, 2021

Conversation

cat5inthecradle
Copy link
Contributor

We released a change to the BlockDeviceMapping that triggered recreation of the EC2 instance. This is not good, as the Daemon server in staging, test, etc

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sureshc
Copy link
Contributor

sureshc commented Nov 15, 2021

Should we set DisableApiTermination to true on the daemon EC2 Instance unless the environment == adhoc?

@sureshc
Copy link
Contributor

sureshc commented Nov 15, 2021

Is there a mechanism we can use to take regular Snapshots of the daemon Volumes with Lifecycle management to prune the old Snapshots? AWS documentation indicates that it’s safest to stop an Instance before taking a Snapshot.

@cat5inthecradle
Copy link
Contributor Author

Is there a mechanism we can use to take regular Snapshots of the daemon Volumes with Lifecycle management to prune the old Snapshots? AWS documentation indicates that it’s safest to stop an Instance before taking a Snapshot.

Definitely safest to stop it - is there a window of time where we can afford to do that? Live snapshots are better than no snapshots though.

When I've done this in the past we implemented a general cloudwatch event and lambda(s) that looked for tags on EC2 instances that defined the backup rules (backup: true, retain: 5 for example). But it looks like nowadays you can use Data Lifecycle Manager.

@cat5inthecradle cat5inthecradle merged commit 20317f4 into staging Nov 16, 2021
@cat5inthecradle cat5inthecradle deleted the avoid-accidental-ec2-recreation branch November 16, 2021 18:50
snickell pushed a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants