Make Instructor and Participant redirect to Teacher and Student #43627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescodeorg
approved these changes
Nov 16, 2021
| const viewType = action.viewType; | ||
| if (!ViewType[viewType]) { | ||
| let viewType = action.viewType; | ||
| if (viewType === 'Instructor') { |
There was a problem hiding this comment.
(minor) It's probably useful to include a comment here to indicate that this is a temporary change, why it's there, and when it's safe to remove. Just in case it lives for longer than we originally intended. :-)
There was a problem hiding this comment.
Thanks for always helping to make our codebase easier to use by making sure we include documentation!
davidsbailey
approved these changes
Nov 16, 2021
snickell
pushed a commit
that referenced
this pull request
Feb 3, 2024
Make Instructor and Participant redirect to Teacher and Student
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step toward updating viewAsRedux to use participant and instructor instead of teacher and student. This PR will make it so you can use
viewAs=InstructorandviewAs=Participantand they will redirect to Teacher and Student views. This should make it safer to merge #43432Links
Testing story