Add DCDO flag for contact rollups #43681
Conversation
Honestly, I think we should keep it. Hopefully we never have to turn this job off but it's good to have the option! |
bin/cron/build_contact_rollups_v2
Outdated
| @@ -21,4 +21,9 @@ ensure | |||
| contact_rollups.report_results | |||
| end | |||
|
|
|||
| def main | |||
| return false unless DCDO.get('contact_rollups_active', true) | |||
There was a problem hiding this comment.
tiny nit: I don't think you need the false here and can just say return unless ...
Sounds good. I suppose if the flag gets deleted, we'd have a problem (could change it to only disabling if there's a flag that says to disable it?) |
I think it would still be okay. If the flag got deleted out of AWS, it would (presumably) be nil and the default would be used instead. I realized that I never thought of sending you the actual code for DCDO flags 🤦♀️ You may have already seen it but here is how that fallback comes into play |
Ah, thank you, Bethany! Super helpful |
+1 for keeping the flag, however it seems like we will still want to remember to turn the flag back on after HOC. @tess323 how do you think we should track this, for this and future years? It seems like the perfect kind of thing to go into whatever the HOC equivalent of our "ship curriculum" doc, which I know we might not quite have yet. |
The flag is on right now, and we aren’t planning to turn it off unless we’re desperate (from what I understand). So I think we just need to create a task to turn it on if we need to turn it off during HoC |
Ohh, I see! OK, that plan sounds good to me. Do we know what symptoms would prompt us to turn off this flag? or if we aren't responsible for that part of it, is this something we should communicate to the infrastructure team so they can put it in their playbook? |
Good questions. I'm going to tap in @tess323 and @clareconstantine as I think they both have more info about who made this original request. |
|
Hey team - I have this included in our HOC launch doc. Most likely we will be offboarding ownership of rollups in spring-summer - so I will make a sure to include this in a handoff doc. I agree it makes sense to keep the flag around for next year or if we need to pause again in the future. After Suresh did some investigation on the rollups - he strongly believes we should turn this off for the week of HOC. I have tasks in this sprint (and next), but lets plan to flip the flag on 12/3 and turn it back on early in the week of 12/15 |
|
Sounds good, Tess! Thanks for the documentation here and adding documentation for the future |
Add DCDO flag for contact rollups
This adds a DCDO flag for contact rollups if we need to turn them off during HOC. I set the flag in production, but not in the other environments (it shouldn't be run in other environments) besides my local environment.
The flag name is
'contact_rollups_active'. It is currently set totrue––to turn off contact rollups, set the flag tofalse.Links
Testing story
I tested on my local environment, setting the DCDO flag in my local dashboard-console. You can also see the flag in AWS.
Deployment strategy
Follow-up work
Question: Do I need to add a task for removing this flag after HOC?
Privacy
Security
Caching
PR Checklist: