Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header: fix project update updates #43709

Merged
merged 2 commits into from Nov 19, 2021
Merged

Header: fix project update updates #43709

merged 2 commits into from Nov 19, 2021

Commits on Nov 19, 2021

  1. Header: fix project update updates 

    It was recently observed that the header's ScriptName component -- which contains the script name and sometimes the ProjectUpdatedAt component below that which shows text like "Saved 2 hours ago" -- was being cropped at its right edge.

While I wasn't able to get a firm local repro, I was able to simulate the suspected issue: the ProjectUpdatedAt component was having its content updated, but the parent ScriptName component didn't know that, so it didn't tell its parent HeaderMiddle component about the newly-desired width.

I'm not sure whether this was always an issue, or something new in a recent React update, but the fix is pretty simple: when the ProjectUpdatedAt component is updated, it informs its parent ScriptName, which then determines the width of the resulting content, and tells its parent HeaderMiddle, which can go about reallocating space appropriately.
    Brendan Reville authored and Brendan Reville committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    00793a6 View commit details
    Browse the repository at this point in the history

  2. Remove temporary code

    Brendan Reville authored and Brendan Reville committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    7586993 View commit details
    Browse the repository at this point in the history