[Google Blockly] Customize variable dropdown options #43741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira
Modeled largely after https://github.com/code-dot-org/blockly/blob/main/core/ui/fields/field_variable.js#L143, which was implemented by #7349
Adds a custom override class for
Blockly.FieldVariable
so that we can overridedropdownCreate
to add our custom rename options to the dropdown andonItemSelected_
to handle the logic for when the rename options are selected. I'm not sure whyonItemSelected_
is a class method anddropdownCreate
is not, but since that's the way it is in Blockly Core, I left it as is in the custom class.Before
After