Remove code break banner below announcement banner on homepage #43781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatieShipley
approved these changes
Nov 23, 2021
snickell
pushed a commit
that referenced
this pull request
Feb 3, 2024
Remove code break banner below announcement banner on homepage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This deletes the
homepage_below_hero_announcement_code_break.hamlpartial and its only reference.Why: We no longer want the banner to show on the code.org homepage for non-English languages.
Links
Testing story
Tested the code.org homepage locally
Before
After
PR Checklist: