Revert "Revert "Show correct state of sign-in button in dashboard"" #43782
Conversation
| @@ -168,10 +170,44 @@ function setupReduxSubscribers(store) { | |||
| setupReduxSubscribers(getStore()); | |||
|
|
|||
| function setUpGlobalData(store) { | |||
| store.dispatch(asyncLoadUserData()); | |||
| fetch('/api/v1/users/current', { | |||
There was a problem hiding this comment.
Should we document this somewhere? I can't tell how widespread this application of fetch might be but if we're moving toward fetch over ajax and the default credentials are still different for older browsers I imagine we'll run into this again?
There was a problem hiding this comment.
I definitely agree. One way to handle this would be to not use fetch directly but write our own wrapper around it so that these kind of configurations will be set for it every time it's used. I'll start a conversation about this in apps-devs tomorrow!
|
|
||
| const displayName = document.querySelector('#header_display_name'); | ||
| displayName.textContent = shortName; | ||
| } else if (!isSignedIn && signinButton.style.display === 'none') { |
There was a problem hiding this comment.
It strikes me that this would be the default- this is a NIT but it might be organizes as just a default 'let' for those two vars with a single 'if' instead.
There was a problem hiding this comment.
I'm not sure I understand what you mean by default 'let' for those two vars. I may follow-up with you on this and get these changes in separately!
maureensturgeon
deleted the
revert-43780-revert-43716-maureen/caching-bug-bash-signin-state
branch
…-maureen/caching-bug-bash-signin-state Revert "Revert "Show correct state of sign-in button in dashboard""
Reverts #43780
Original PR: #43716
The issue: I was calling
fetchwithout explicitly specifyingcredentials. For some ranges of browsers the default is omit (see https://github.com/github/fetch#sending-cookies), meaning that cookies are not sent along with the request and in my case this resulted in the server missing the current logged in user and sending backis_signed_in: falsefrom the API. Sendingcredentials: same-originmeans that cookies will be sent with the request when it's made to the same origin (in our casestudio.code.org)