-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Scoop of HoC LevelBuilder content #43827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes to poetry files are expected and look good to me!
@@ -0,0 +1,1624 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did someone request that we ship this survey? i'm not too concerned about it (it seems low risk), mostly just wondering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, request came in from Tess and Baker
"encrypted_examples": [ | ||
|
||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@code-dot-org/curriculum-platform it looks innocuous, but is an empty array for encrypted_examples
expected here? i would've assumed that the value would either be null
or an encrypted string (like the change to poetry_hoc_spriteSizes.level
below), but i'm not super familiar with this so i want to double-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question Maddie! it's a bit strange that this diff is showing up, especially given that this level has been edited recently. overall this looks like a cosmetic change to me and I wouldn't be worried about it breaking anything, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the .script_json files look good to me. I'm not too familiar with the other content. I would just note that we've been having some problems with PDF generation lately, so it could be worth checking that the PDFs for these scripts/lessons are working on staging before we DTP this change. e.g. https://staging-studio.code.org/s/poetry-2021?viewAs=Instructor --> Printing Options
Manual Scoop of HoC LevelBuilder content
For triage on 11/30
Manual scoop of 5 files required for Hour of Code. 4 are for Poetry and one is a foorm survey.