Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Scoop of HoC LevelBuilder content #43827

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

aaronwaggener
Copy link
Contributor

For triage on 11/30
Manual scoop of 5 files required for Hour of Code. 4 are for Poetry and one is a foorm survey.

Copy link
Contributor

@mikeharv mikeharv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes to poetry files are expected and look good to me!

@@ -0,0 +1,1624 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did someone request that we ship this survey? i'm not too concerned about it (it seems low risk), mostly just wondering

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, request came in from Tess and Baker

Comment on lines +43 to +45
"encrypted_examples": [

],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-dot-org/curriculum-platform it looks innocuous, but is an empty array for encrypted_examples expected here? i would've assumed that the value would either be null or an encrypted string (like the change to poetry_hoc_spriteSizes.level below), but i'm not super familiar with this so i want to double-check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question Maddie! it's a bit strange that this diff is showing up, especially given that this level has been edited recently. overall this looks like a cosmetic change to me and I wouldn't be worried about it breaking anything, though.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the .script_json files look good to me. I'm not too familiar with the other content. I would just note that we've been having some problems with PDF generation lately, so it could be worth checking that the PDFs for these scripts/lessons are working on staging before we DTP this change. e.g. https://staging-studio.code.org/s/poetry-2021?viewAs=Instructor --> Printing Options

@aaronwaggener aaronwaggener merged commit d508c03 into staging Nov 30, 2021
@aaronwaggener aaronwaggener deleted the levelbuilder_hoc_11292021 branch November 30, 2021 17:11
snickell pushed a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants