Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application idempotency fix #43868

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Application idempotency fix #43868

merged 1 commit into from
Dec 1, 2021

Conversation

tim-dot-org
Copy link
Contributor

@tim-dot-org tim-dot-org commented Dec 1, 2021 •
edited

When submitting an application, we were still checking for uniqueness of user id and that we don't conflict with any application for that user. We actually want to filter by application year first. This was missed when doing the larger teacher application refactoring.

Links

Testing story

Tested locally with a manually created older application associated with the user.
testing steps:

  • Submitted an application with logged in user.
  • Went into dashboard-console and manually changed the application_year to a previous year ("2021-2022") and verified that it allowed me to start creating a new application
  • Verified that submitting another application brought us back to the first page with the data cleared
  • Made the fixes
  • Verified that submitting another application rendered the application submitted page instead

Deployment strategy

@tim-dot-org tim-dot-org changed the base branch from staging-next to staging December 1, 2021 20:32
@tim-dot-org tim-dot-org merged commit 2583ed3 into staging Dec 1, 2021
@tim-dot-org tim-dot-org deleted the application-idempotency-fix branch December 1, 2021 21:09
snickell pushed a commit that referenced this pull request Feb 3, 2024
@tim-dot-org
Merge pull request #43868 from code-dot-org/application-idempotency-fix
a5f1e25 
Application idempotency fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tim-dot-org @davidsbailey @bethanyaconnor