assert_nil to make Drone logs slightly more user-friendly #44150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeharv
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drone logs can be tricky to parse. One strategy is to search
failto try to find the error in a failing run. Doing so shows a handful of deprecation warnings, for example:DEPRECATED: Use assert_nil if expecting nil from test/controllers/scripts_controller_test.rb:996. This will fail in Minitest 6.To reduce noise and thereby make it slightly easier to find the real failures, I've updated offending tests to use
assert_niland updated a few of the skip messages we left for ourselves.