Fix check for blank lines in poems #44180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were checking for a blank line by checking that it contained at least one alphanumeric character. This caused issues with lines containing punctuation, and some non-english poems. Thing change now checks for specific blank lines.
Before:
bug.blank.lines.mov
After:
Blank.Line.Fix.mov
fix.blank.line.french.mov
Links
PR Checklist: