convert Congrats and Certificate into functional components #44237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megcrenshaw
reviewed
Jan 7, 2022
| const facebook = queryString.stringify({ | ||
| u: certificateLink | ||
| }); | ||
| const certificate = certificateId || 'blank'; |
There was a problem hiding this comment.
style nit: Could make blank a defaultProp and avoid this, but I realize it's not what was there previously
There was a problem hiding this comment.
(i.e. don't think it's worth a whole new build for it)
There was a problem hiding this comment.
good call! I will include this in the next PR, where I am touching some of this code anyway.
megcrenshaw
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a warm-up step for starting on PLAT-1531.
Testing story