don't clone deprecated blockly levels #44255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated blockly levels cause problems when cloned, and should be skipped (here, we return the old blockly level)
Specifically, they cause a validation failure on uniqueness of the level_num field:
code-dot-org/dashboard/app/models/levels/level.rb
Lines 48 to 54 in 5aad68f
See: https://docs.google.com/document/d/1rS1ekCEVU1Q49ckh2S9lfq0tQo-m-G5KJLiEalAzPts/edit#heading=h.2buyj1ahym0m
Testing story
Couldn't repro locally, but tested with these changes in levelbuilder for
pre-express
and looks good!