Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INF-506 fix prod redirect url #44278

Merged
merged 5 commits into from
Jan 10, 2022
Merged

Conversation

cat5inthecradle
Copy link
Contributor

Prod is special, but the redirect lambda assumed prod was just like staging and test, which meant that it is set up to redirect to autoscale-prod.code.org instead of the special prod additional URL code.org. Similar to how we needed to conditionally specify a Subject Alternative Name for the certificate in prod, we need to have prod redirect to this URL instead.

Links

Jira Tickets

Follow-up work

Continue INF-506 and INF-543

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@cat5inthecradle cat5inthecradle requested a review from a team January 7, 2022 23:25
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor syntax/code organization nits, but overall LGTM!

aws/cloudformation/components/www_redirect.yml.erb Outdated Show resolved Hide resolved
aws/cloudformation/components/www_redirect.yml.erb Outdated Show resolved Hide resolved
cat5inthecradle and others added 4 commits January 10, 2022 09:19
Co-authored-by: Elijah Hamovitz <elijahhamovitz@gmail.com>
…rg/code-dot-org into inf-506-fix-prod-www-redirect
@cat5inthecradle cat5inthecradle merged commit 5b8d2da into staging Jan 10, 2022
@cat5inthecradle cat5inthecradle deleted the inf-506-fix-prod-www-redirect branch January 10, 2022 16:53
@cat5inthecradle
Copy link
Contributor Author

Following up after the staging deploy. This PR caused no actual changes to the cloudformation template, so that means my understanding of the variables/functions was correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants