Katleiah/gb danceparty fielddropdown #44313
Conversation
| const isMissingSecondValue = menuGenerator.some( | ||
| entry => entry.length === 1 | ||
| ); | ||
|
|
||
| if (isMissingSecondValue) { | ||
| menuGenerator = menuGenerator.map(entry => { | ||
| return [entry[0], entry[0]]; | ||
| }); | ||
| } |
There was a problem hiding this comment.
I think Ideally we could move a lot of this logic out of the constructor and into their own methods, but when I did that I got an error that I couldn't call this before super(). Open to ideas, but also ok leaving it here if that ends up making the most sense.
katleiahramos
force-pushed
the
katleiah/gb-danceparty-fielddropdown
branch
from
0705e89
to
4354c6d
Compare
apps/src/block_utils.js
Outdated
| dropdownOptions.forEach(option => { | ||
| if (option.length === 1) { | ||
| newOptions.push([option[0], option[0]]); | ||
| } else { | ||
| newOptions.push(option); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I think this is a slightly more performant way to handle the logic. Let me know if you think this change makes sense!
There was a problem hiding this comment.
nit: might be slightly cleaner as a map like return options.map(option => option.length === 1 ? [option[0], option[0]] : option)
There was a problem hiding this comment.
I like doing this in a separate function so that we can have a doc comment for it :)
There was a problem hiding this comment.
great idea! updated here: eed89ab
apps/src/block_utils.js
Outdated
| /** | ||
| * Adds a second value to options array elements if a second one does not exist. | ||
| * The second value is used as the generated code for that option. | ||
| * Also required for backwards compatibility with existing blocks that are missing the second value. |
There was a problem hiding this comment.
updated here: eed89ab!
Existing error:
Links
Jira Ticket
Testing story
Manually Testing:
PR Checklist: