Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Lab file explorer: increase dropdown size #44383

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

molly-moen
Copy link
Contributor

Scrollbars won't always appear on Macs (this is a system-wide Mac setting that can't be overwritten with css). To make it clear if there are additional items in the file explorer dropdown, increase the dropdown size to always show a half item.
Dropdown with scrollbar hidden:
Screen Shot 2022-01-14 at 3 54 09 PM

Dropdown with scrollbar visible:
Screen Shot 2022-01-14 at 3 51 21 PM

Links

Testing story

Tested locally with scrollbar hidden and visible.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested a review from a team January 14, 2022 23:55
@molly-moen molly-moen changed the title Java Lab file explorer: increase dropdwon size Java Lab file explorer: increase dropdown size Jan 15, 2022
@molly-moen molly-moen merged commit 95b72c5 into staging Jan 19, 2022
@molly-moen molly-moen deleted the increase-dropdown-size branch January 19, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants