Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always save level after cloning concept difficulty #44403

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

bethanyaconnor
Copy link
Contributor

The level concept difficulty was cloning correctly in the database but wasn't being written to the level file. This is because we write the file in an after_save hook, but we were only saving when changed? was true. However, when a relationship is assigned, the object itself isn't changed, so changed? returns false.

I couldn't figure out a good way to update the unit tests for this but I did confirm locally that this change writes the level concept difficulties on clone.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor requested a review from a team January 19, 2022 00:29
@bethanyaconnor bethanyaconnor merged commit b80f203 into staging Jan 19, 2022
@bethanyaconnor bethanyaconnor deleted the write-cloned-concept-difficulty branch January 19, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants