Do not check for family on unit in a unit group for validation across family #44494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethanyaconnor
approved these changes
Jan 24, 2022
| return nil if family_name.nil_or_empty? | ||
|
|
||
| all_family_courses = nil | ||
|
|
||
| if is_a?(UnitGroup) || (is_a?(Script) && unit_group) | ||
| if is_a?(UnitGroup) |
There was a problem hiding this comment.
According to the comment, if this is a script in a unit group we should be checking the unit group's family name right? I think that's what you're removing here, but should this method return nil or the empty array?
There was a problem hiding this comment.
Updated the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a unit in CSP errors were showing up:
When saving a unit that does not have a family name (is in a unit group) we should not be checking to see if it is consistent with other units in a family.
Links
Slack
Testing story