Check Terms of Service Version Through Users Table Instead of Cookie

[TurnerRiley]

The terms of service dialog that appears to Users logging in for the first time from Clever or Powerschool currently looks at a cookie, which is how it was before we revamped the dialog to exclude the out-of-date terms of service. This means that if the user logs in from a different device or clears their cookies, they’ll see the dialog again, which is not desired behavior.

Since we already track terms_of_service_version (i.e. the most recent ToS version the user has accepted) in the User model, now the behavior is to just check whether the terms_of_service_version matches the most recent ToS version. If they don't match, show them the new ToS for them to accept, otherwise don't show it to them.

Links

Jira ticket: here
PR for revamped dialog avoiding out-of-date ToS: here

Testing story

Localhost testing through Clever test accounts to ensure that upon their first logins users see the ToS dialog but don't see it on subsequent ones (even if they clear their cookies or log in elsewhere). I specifically tested this by logging in in an incognito window and then closing it, then opening a new incognito window and repeating the process to check for the correct behavior.

Demo using the incognito windows: here

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked