Revert "Revert "Update Pegasus HoC helper to use i18n backend"" #44501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacodeorg
approved these changes
Jan 25, 2022
smusoke
deleted the
revert-44491-revert-44240-fnd-1816-hoc-string-tracking
branch
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44491 with a fix implemented.
In the original PR we updated our
testenvironment to not load all locales into the i18n backend in order to fix test timeout issues. An eyes test for hourofcode.com/br was not accounted for, so we are loading the extra necessary translation file here.Slack thread