SummaryProgressRow refactor #44504
Merged
SummaryProgressRow refactor #44504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescodeorg
approved these changes
Jan 26, 2022
Comment on lines
+28
to
+32
| // The parent component filters out hidden SummaryProgressRows from the student view, | ||
| // this check is just to ensure it won't be rendered if it should be hidden for students | ||
| if (lessonIsHiddenForStudents && viewAs === ViewType.Participant) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Should we take advantage of this refactoring and use the "participant" terminology here instead (in the comment and in the prop name)?
There was a problem hiding this comment.
That did cross my mind as I was writing.. "student" just seemed so much more clear to me.. and right next to it is lessonIsHiddenForStudents. I'm going to leave it for now since I don't want to wait for another drone run, in the future I'll use participant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working on end-of-lesson dialog/redirect I discovered that the SummaryProgressRow test was testing a prop that was not used, which is what kicked off this refactor.
Changes:
PR Checklist: