Adding codeorg-api.com and xeno-canto.org #44520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://xeno-canto.org/explore/api is a bird sounds API requested by a student https://codeorg.zendesk.com/agent/tickets/370728 https://docs.codeorg-api.com/ is a student created API to connect two or more clients through a server for game development https://codeorg.zendesk.com/agent/tickets/369165
| @@ -63,6 +63,7 @@ class XhrProxyController < ApplicationController | |||
| api.zippopotam.us | |||
| bible-api.com | |||
| code.org | |||
| codeorg-api.com | |||
There was a problem hiding this comment.
we should add a comment (maybe with a link to the documentation) to make it clear that this API isn't owned/maintained by code.org. ruby doesn't support comments in a %w() block like this, so the comment will have to go at the top (where the other 'code.org' comment is), unfortunately
There was a problem hiding this comment.
Great callout Maddie - I'll add that comment
maddiedierker
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://xeno-canto.org/explore/api is a bird sounds API requested by a student https://codeorg.zendesk.com/agent/tickets/370728
https://docs.codeorg-api.com/ is a student created API to connect two or more clients through a server for game development https://codeorg.zendesk.com/agent/tickets/369165