Revert "Revert "When generating PLC course set all course type and published state information"" #44534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44533. Reimplements #44478
When this was merged to staging the build failed because andrea-test script had null values for published_state, instruction_type, instructor_audience, participant_audience. We have been allowing null values for these fields on scripts because if they are in a unit_group then they should be null however it looks like we need some stronger validation here. Working on that in #44538.
Updated the andrea-test.script_json and ran
bundle exec rake buildto make sure that the build passes. Added default values for right now in order to make sure seeding does not fail if something were to get messed up again before the validation is added.