Remove period at the end of lesson keys in csf

[dmcavoy]

Names of lessons were showing that they could not be translated for some lessons. After investigating we determined it was because of a period in the key for the lesson. This removes periods from names of existing lessons that were causing issues to unblock curriculum writers.

Thanks @bethanyaconnor for your help investigating this.

Links

Slack Convo

Testing story

• Ran bundle exec rake build to make sure things build ok
• Checked that these lessons no longer show the translation error message

Follow-up work

• Make sure when new lessons are made or lessons are copied we do not end up with periods in the key

[megcrenshaw]

Will this also get messed up? Or is it only at the end of the key?

[dmcavoy]

This was also an issue. You can see Hannah linked to it in the slack thread

[megcrenshaw]

When I do a regex search in RubyMine for "lesson\.key": ".*\." I get matches from coursea, courseb, and coursec. If the period is also not allowed within the key itself, I'll re-search

[bethanyaconnor]

Thanks for fixing these!

[dmcavoy]

When I do a regex search in RubyMine for "lesson\.key": ".*\." I get matches from coursea, courseb, and coursec. If the period is also not allowed within the key itself, I'll re-search

Its not allowed anywhere in the key it looks like.

[dmcavoy]

@megcrenshaw feel free to do another search and report back on findings. I'm going to merge this to unblock writers.

[megcrenshaw]

@dmcavoy Thanks for the clarification! I'm also seeing it in cspassessment.script_json ("lesson.key": "NOTE: Deprecated. Teacher cannot see results. CSP Culminating Assessment") and equity-pd.script_json ("lesson.key": "Code.org Equity PD"). That's all I see. Searching "lesson\.key": ".*\..*" in RubyMine

[dmcavoy]

@megcrenshaw thank you! Here is the follow up PR #44742