Add UI tests for code review groups #44795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
ben/code-review-groups/ui-tests-minimal
to
ben/code-review-groups/clean-up-backend
February 14, 2022 17:28
jmkulwik
approved these changes
Feb 15, 2022
Base automatically changed from
ben/code-review-groups/clean-up-backend
to
staging
March 8, 2022 18:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI tests for code review groups management UI in the teacher dashboard.
Testing story
Tests passed locally.
Follow-up work
I initially had an eyes test here as well, but noticed in Applitools that the lower half of the UI is blocked on smaller screens -- that work is in this ticket:
https://codedotorg.atlassian.net/browse/JAVA-382
I put the eyes test code that I wrote as a comment in the item above, such that it could be added when that work is completed.