Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage: restore gap for non-en users #44809

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

breville
Copy link
Member

Restores a gap on the signed-out https://code.org/ homepage for non-en users. (Not sure when this regressed.)

before

Screen Shot 2022-02-14 at 9 13 48 AM

after

Screen Shot 2022-02-14 at 9 17 59 AM

@breville breville requested review from KylieModen, a team and molly-moen February 13, 2022 22:28
Copy link
Contributor

@KylieModen KylieModen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great catch

@breville breville merged commit 58079a9 into staging Feb 14, 2022
@breville breville deleted the homepage-gap-non-en branch February 14, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants