DTT (Staging > Test) [robo-dtt] #44855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 6 changed the way ActionView expects to be initialized. Within Pegasus, we are using a modified version of ActionView to render templates and so that modification needs to be updated. The nature of our modification includes storing a reference to Sinatra within the instance of ActionView that we initialize; our original implementation simply added a new required initialization variable but the new Rails 6 initialization logic makes that more difficult. So instead, we manually set the instance variable after initialization. This is obviously much clumsier than the original approach, but should be easier to maintain. The increased complexity of our new initialization logic is all captured in a new factory method.
DTL (Test > Levelbuilder: 05e9434)
DTS (Levelbuilder > Staging) [robo-dts]
Add Rails 6 Compatibility to ActionViewSinatra
Do a full seed on adhoc setup
Remove status from form data after status gets set
make certificate share page responsive, and add call-to-action
X button in Finish Dialog for Dance closes modal instead of redirecting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.