Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Event Param from OnBoardEvent [Circuit Playground] #44860

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

epeach
Copy link

@epeach epeach commented Feb 15, 2022

Extension of #43973 to apply to Circuit Playground blocks.

We want to remove the 'event' parameter from onBoardEvent since we don't require it to be used and it adds a linter warning to student code (yellow triangle). Per curriculum request.

Screenshot from 2022-02-15 15-44-04

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@epeach epeach changed the title Remove event param Remove Event Param from OnBoardEvent [Circuit Playground] Feb 15, 2022
@epeach epeach requested a review from a team February 15, 2022 23:45
@epeach epeach merged commit 832da27 into staging Feb 17, 2022
@epeach epeach deleted the maker-onBoardEvent-param branch February 17, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants