Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead code related to certificate link test #44867

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Feb 16, 2022

as part of the congrats page work, I noticed some existing code that isn't being used. slack history suggests it was last used more than 5 years ago for manual testing of new HOC certificates.

Testing story

none needed that I can think of. this PR removes dead code and corresponding unit tests.

@davidsbailey davidsbailey changed the title Remove certificate link test remove dead code related to certificate link test Feb 16, 2022
@davidsbailey davidsbailey requested a review from a team February 16, 2022 17:26
@davidsbailey davidsbailey marked this pull request as ready for review February 16, 2022 17:26
Copy link
Contributor

@jamescodeorg jamescodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favorite kind of code reviews!

@davidsbailey davidsbailey merged commit c03057a into staging Feb 16, 2022
@davidsbailey davidsbailey deleted the remove-certificate-link-test branch February 16, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants