[Maker][CP] - Use blank array param for buzzer

[epeach]

Curriculum request to style the block parameters for buzzer.playSong/playNotes. Old notes were displayed in a vertical array to minimize impact of a really long array. This change removes the default values placed in the array. PlayNotes uses an empty array and PlaySong uses an array with spaces - discussion here: https://codedotorg.slack.com/archives/C0T0EGE8L/p1644507117916229

Before / After in Blocks:

Before/After in Text:

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[maddiedierker]

just read through the thread and it looks like some updates might be coming through, so i'll hold off until then. in the meantime, it looks like buzzer.play is now the only block that uses stringifySong:

code-dot-org/apps/src/lib/kits/maker/dropletConfig.js

Lines 295 to 301 in e262b1c

	{
	func: 'buzzer.play',
	category: CIRCUIT_CATEGORY,
	paletteParams: ['notes', 'tempo'],
	params: [stringifySong(SONG_CHARGE), 120],
	paramButtons: {minArgs: 1, maxArgs: 2}
	},

do we want to update/change the default for that block as well?

[epeach]

@madelynkasula - I had the same thought and made a ticket to track it! https://codedotorg.atlassian.net/jira/software/c/projects/STAR/boards/26?modal=detail&selectedIssue=STAR-2103

I wanted to split it out because I want to get this change out ASAP for curriculum and want to make sure I'm deprecating carefully. We only use buzzer.play internally and it does the same things as PlaySong, so we should just remove Play (and stringifySong).

[maddiedierker]

left a nit comment/question, but it's not a merge-blocker

[maddiedierker]

nit: SONG_CHARGE[0] is the same as SONG_SINGLE_NOTE -- should we use that instead?

[epeach]

SONG_CHARGE[0] is ['G3', 0.25] and SONG_SINGLE_NOTE is ['G3']. PlayNotes takes a one dimensional value (note) and PlaySong takes two dimensional (note, length).

[maddiedierker]

ahh, my bad!