add ui tests for dashboard certificate pages #44909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
changed the base branch from
staging
to
generate-congrats-sponsor
maureensturgeon
approved these changes
Feb 18, 2022
|
Good idea! I will add eyes tests in the next PR. |
This was referenced Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues PLAT-1531. Depends on #44866. see work plan
Testing story
Add new UI test coverage for two basic flows with experiment enabled:
I am relying on unit tests in CertificateTest.js to enforce that we do not end up on any of these new pages when the experiment is not enabled.
These are all the UI tests I am planning to add before shipping the experiment, so if you think others would be good to add then now would be a good time to suggest them.