[micro:bit] Setup Checklist - Remove 4th Check #44954
Conversation
| {this.installFirmwareSketch()} | ||
| {this.contactSupport()} | ||
| </ValidationStep> | ||
| {this.state.boardTypeDetected !== BOARD_TYPE.MICROBIT && ( |
There was a problem hiding this comment.
it feels a little confusing to have this step render then disappear once we know it's a micro:bit. could we invert this logic and only show this step for boards that should have it? alternatively, we might be able to check that boardTypeDetected && boardTypeDetected !== BOARD_TYPE.MICROBIT to get the same outcome
There was a problem hiding this comment.
@KylieModen - I'd love your input here. I think Maddie's point makes sense, but that would change the current behavior for CP, vs. this change which keeps the current UI the same for CP, but changes for MB. Thoughts?
There was a problem hiding this comment.
I agree the flashing feels weird - I also don't love the order changing for what gets the thumbs up
Is there any other way to not display anything initially to avoid the flash? that way CP users see what they always have, and MB users will only see their UX?
There was a problem hiding this comment.
That's a tough one - the board is detected at the second step - so we don't know whether we need 3 or 4 steps until them. So we could display only each step when it's completed and not the "pending" grey step? So the behavior for CP would change a little bit, but each group would only see the steps applicable to them.
There was a problem hiding this comment.
Mocked it up so we could see what that might look like:
| .then(serialPort => this.boardClient_.connectBoard(serialPort)) | ||
| .then(() => { | ||
| if ( | ||
| this.boardClient_.firmwareVersion.includes('micro:bit Firmata 1.1') |
There was a problem hiding this comment.
nit: 'micro:bit Firmata 1.1' should probably be a constant at the top of the file for easy visibility -- it feels a little hidden here
|
@madelynkasula - PTAL! Thanks! |
The previous code here wasn't catching connection errors. As we move closer to a Beta release, I wanted to loop back and make sure we were handling connection errors appropriately.
This change adds a catch to the 'connect' process for the micro:bit to catch and throw errors when needed. I tested locally by forcing the connection to fail (returning a failed promise in MBFirmataWrapper).
This PR also includes changes to add an additional check at the third step for the micro:bit. This check requests the firmware version from the micro:bit. The value we expect back includes markers that can help us determine if the board has outdated firmware on it. If the firmware version doesn't match our expectations, we fail the step and the user is served information about flashing the correct Firmata to their board.
Finally, this board removes the 4th step, see gif. This fourth step is relevant to the set-up for the Circuit Playground and doesn't have an analogous step for micro:bit. The expected behavior is that once a micro:bit is detected, we no longer render the fourth step and the third step now displays the thumbs-up icon when the process is complete.
Before:
After:
After discussing in the comments below, we are updating the final outcome so that 'waiting' steps aren't shown. See gifs.
PR Checklist: