Add navigation to code docs pages #44961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethanyaconnor
force-pushed
the
block-docs-navigation
branch
from
50028cc
to
b3c5bb9
Compare
bethanyaconnor
changed the title
tim-dot-org
approved these changes
Feb 24, 2022
| import {expect} from '../../../util/reconfiguredChai'; | ||
| import PageContainer from '@cdo/apps/templates/codeDocs/PageContainer'; | ||
|
|
||
| describe('PageContainer', () => { |
There was a problem hiding this comment.
this file is named "PageContainerText" instead of Test :p
There was a problem hiding this comment.
🤦♀️ I do this all the time but normally I catch it. Thanks!
| currentCategoryKey | ||
| }) { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
this div could be a <></>
bethanyaconnor
force-pushed
the
block-docs-navigation
branch
from
14b263c
to
0a8c2b3
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds navigation to code docs! Creates
PageContainerthat addsNavigationBarto the left side of the page and the rest of the page, passed in aschildrento fill the rest of the page.And just like on curriculumbuilder, the sections open and close when clicked
Screen.Recording.2022-02-23.at.8.31.41.AM.mov
Follow-up work
Privacy
Security
Caching
PR Checklist: