Removing onContinue redirect from the default close button in Legacy Dialog

[hannahbergam]

The major update of this PR: when a user presses the x button on the legacy dialog feedback/finish popup, instead of being redirected to the next level, the dialog closes. This was updated in a recent pr for the level type dance (jira ticket: https://codedotorg.atlassian.net/browse/LP-2192).

This is a simplification, removing the variable 'hideButDontContinue' entirely, as well as the onContinue() default from the onHidden function.

AI lab and fish are the only level types with their own onContinue() functions that report progress: neither of these uses a dialog at all, so progress will not be lost when removing this default here.

Links

• spec:
• jira ticket: https://codedotorg.atlassian.net/browse/LP-2222

Testing story

There is now a series of steps in hour_of_code.feature to verify that when the x button is pressed in the legacy dialog, you remain on the same page instead of moving to the next level in a redirect. The other tests remain unchanged, but are updated so that the user must press the continue button to move to the next level.

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked